From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCfO-00060i-Uz for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:30:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKCfN-0004gf-Qq for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:30:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCfN-0004fK-Gm for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:30:29 -0400 Message-ID: <506F2730.6090106@redhat.com> Date: Fri, 05 Oct 2012 12:30:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> <1349460425-30601-4-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig722A5E32E190B2A367382AEA" Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: libvir-list@redhat.com, kwolf@redhat.com, Corey Bryant , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig722A5E32E190B2A367382AEA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/05/2012 12:25 PM, Blue Swirl wrote: > On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote: >> These new options can be used for passing drive file descriptors >> on the command line, instead of using the file option to specify >> a file name. >> >> These new command line options mirror the existing add-fd QMP >> command which allows an fd to be passed to QEMU via SCM_RIGHTS and >> added to an fd set. The opaque option is also available with >> add-fd, and allows a free-form string to be stored in the fd set >> along with the fd. >> >> + .name =3D "opaque", >=20 > 'opaque' is not very descriptive and it's also not obvious (except > from the help text) that it's only interesting for file descriptors. > How about fd_name, fd_tag or fd_descr? Hmm, since opaque is per-fd in the existing monitor command, that means my proposal needs a slight modification to: -fdset set=3D1,fd=3D24,opaque=3D"rdonly",fd=3D25,opaque=3D"rdwr" or some other way where we can specify multiple fds and multiple opaque strings per set. At any rate, this just proves that we need to nail down the command line implementation to something that is easy enough to use, before coding up something that locks us in to bad design. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig722A5E32E190B2A367382AEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQbycwAAoJEKeha0olJ0NqbSUH/Rr2tvxQMt6Nk8j2+yW+uTGG 5L5unR8ggU7HQDQ1IkEttN2l22F7Da1kvrXL05KMf0qQPQB1IsT9/fT0VccoOUfL b0BcZln6IoSYfY7BjeOE6G6jFM6L3HxUlfIorvv5cdW+HlerR5CWE90wemAUOWkK yhtxoFjvV/12ySOTqSL6Dsdj4C4p9NMzCt1HM29eADmludOPm+sRhL7+4Uffxh0Q iC2Svi9P5ehpsvhImKYroVhG6ns+RSYAj4F8X9h+eYAAZD6h2csQ5Xv5ZXCST/k3 n77b5VR5egsMdx0LyehzIX5B/xbXpxjPggxSstFwTOJup++qESGMc3zRSZfYG3w= =HdEQ -----END PGP SIGNATURE----- --------------enig722A5E32E190B2A367382AEA--