From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCnK-0001uQ-0l for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:38:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKCnI-0007Tf-Nb for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:38:41 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:39273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCnI-0007TZ-Gy for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:38:40 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Oct 2012 12:38:39 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 8E39F19D8042 for ; Fri, 5 Oct 2012 12:38:35 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q95IcLUV146344 for ; Fri, 5 Oct 2012 12:38:21 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q95IbxWw032310 for ; Fri, 5 Oct 2012 12:37:59 -0600 Message-ID: <506F2901.7030901@linux.vnet.ibm.com> Date: Fri, 05 Oct 2012 14:37:53 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> <506F2648.2020605@redhat.com> In-Reply-To: <506F2648.2020605@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: libvir-list@redhat.com, kwolf@redhat.com, qemu-devel@nongnu.org On 10/05/2012 02:26 PM, Eric Blake wrote: > On 10/05/2012 12:07 PM, Corey Bryant wrote: >> This series adds command line file descriptor passing support >> to the -drive option. This is a follow-on to the existing >> QMP fd passing support provided in the following patch series: >> comments.gmane.org/gmane.comp.emulators.qemu/165463 >> >> An example of using the new -drive fd and opaque options: >> qemu-kvm -drive fd=24,opaque="rdwr:/path/file",index=0,media=disk > > This feels wrong. Now you have to special-case encode the > fd=nn,opaque=xyz handling to EVERY command line argument that takes a > file name, not just -drive. > > I'd much rather see: > > qemu-kvm -fdset set=1,fds=24,25 \ > -drive file=/def/fdset/1,index=0,media=disk > > Where the creation of fdsets happens independently from use of those > sets, and therefore all other arguments that take file names can just > magically take the /dev/fdset/nnn notation that we already support from > the monitor. > > Besides, my approach will let me pass in an O_RDONLY fd on 24 and O_RDWR > on 25 into the same set, whereas your approach creates a new set per fd, > so I can't add new fds to the set until the monitor is up and running. > Thanks for the quick feedback. I like your idea here. Much more flexible. -- Regards, Corey Bryant