From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKD68-0003z7-GP for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:58:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKD67-0007Tk-DU for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:58:08 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:49328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKD67-0007TX-6t for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:58:07 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Oct 2012 12:58:04 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id DF0D6C40004 for ; Fri, 5 Oct 2012 12:57:56 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q95Iw1XB189192 for ; Fri, 5 Oct 2012 12:58:01 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q95Ixd6I026834 for ; Fri, 5 Oct 2012 12:59:39 -0600 Message-ID: <506F2DB7.4090003@linux.vnet.ibm.com> Date: Fri, 05 Oct 2012 14:57:59 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> <1349460425-30601-4-git-send-email-coreyb@linux.vnet.ibm.com> <506F2730.6090106@redhat.com> <506F2A9D.6050605@linux.vnet.ibm.com> <506F2C32.4010909@redhat.com> In-Reply-To: <506F2C32.4010909@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Blue Swirl , libvir-list@redhat.com, qemu-devel@nongnu.org, kwolf@redhat.com On 10/05/2012 02:51 PM, Eric Blake wrote: > On 10/05/2012 12:44 PM, Corey Bryant wrote: >> Yes, this makes more sense. I'd like to mirror the add-fd QMP command >> as much as possible: >> >> { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'}, >> 'returns': 'AddfdInfo' } >> >> So maybe we can make it: >> >> -add-fd fd=24,fdset-id=1,opaque="rdonly" -add-fd >> fd=25,fdset-id=1,opaque="rdwr" > > Sounds better. Note that while fdset-id is optional in QMP, I think it > needs to be mandatory on the CLI (you're telling qemu to use an > inherited fd, but unless you know what set that fd belongs to, you can't > then refer to that fd elsewhere on the command line, and unlike the QMP > command, there is no venue for QMP to tell you what set was autocreated). > I agree the fdset ID should be mandatory on the command line so we can link up other commands like '-drive file=/dev/fdset/nnn' where nnn is the fdset ID. > Bike-shedding: I think the command line can be slightly shorter with: > > -add-fd fd=24,set=1,opaque=... > Sure, I have no problem with shortening it. -- Regards, Corey Bryant > with no real loss in information (that is, s/fdset-id/set/), since our > command lines are already quite long. But going longhand to match QMP > doesn't hurt my feelings (libvirt will be automating this all anyway, so > I won't really be typing it by hand). >