From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKoCU-0005oC-JL
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 06:35:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKoCT-0005NK-5t
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 06:35:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKoCS-0005MT-St
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 06:35:09 -0400
Message-ID: <50715AD2.8010207@redhat.com>
Date: Sun, 07 Oct 2012 12:34:58 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1349280245-16341-1-git-send-email-avi@redhat.com>
	<1349280245-16341-20-git-send-email-avi@redhat.com>
	<CAAu8pHtDW7Hi+JY7SqgQfNx+KpjSbBJAUrUS+nKkOs84K2OxEA@mail.gmail.com>
	<506D2EEE.3010904@redhat.com>
	<CAAu8pHteUoFGP1BvOzpjRbyhJ+4FUfCT=9tm8a=CSWD0ouxRkw@mail.gmail.com>
	<506DC530.7040801@redhat.com>
	<CAAu8pHuzJKDe8PsXe4qZp8N5taqHUH_eAXrGE2UD29D-Eqgnxg@mail.gmail.com>
	<871uhejbvu.fsf@codemonkey.ws>
	<CAFEAcA-LgipRQQ1rn_WSaMXLh1V_LQh4VrESF1i1t2peRKyS+Q@mail.gmail.com>
In-Reply-To: <CAFEAcA-LgipRQQ1rn_WSaMXLh1V_LQh4VrESF1i1t2peRKyS+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, liu ping fan <qemulist@gmail.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>

On 10/04/2012 09:16 PM, Peter Maydell wrote:
> On 4 October 2012 20:05, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Blue Swirl <blauwirbel@gmail.com> writes:
>>> They can all be 64 bits, I'm just considering types. Getting rid of
>>> target_phys_addr_t, pcibus_t, pio_addr_t and dma_addr_t (are there
>>> more?) may be also worthwhile.
>>
>> Where this breaks down is devices that are DMA capable but may exist on
>> multiple busses.
>>
>> So you either end up with a device-specific type and a layer of casting
>> or weird acrobatics.
>>
>> It makes more sense IMHO to just treat bus addresses as a fixed with.
>>
>> target_phys_addr_t is a bad name.  I'd be in favor of either just using
>> uint64_t directly or having a generic dma_addr_t.
> 
> I agree that we only need one type; I think it's helpful to
> have a type name rather than direct use of uint64_t. dma_addr_t
> doesn't seem right because most of the usage of it isn't going to
> be in DMA related contexts. addr_t ?

*_t is reserved.

Suggestions:

 phys
 Phys
 hwaddr
 hw_addr

there are some variables named 'phys' scattered in the source, so my
current favorite is hwaddr.  Short and to the point.

-- 
error compiling committee.c: too many arguments to function