From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47244)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKqiw-00005c-VY
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 09:16:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKqiw-0007J4-2w
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 09:16:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9555)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TKqiv-0007J0-Qh
	for qemu-devel@nongnu.org; Sun, 07 Oct 2012 09:16:50 -0400
Message-ID: <507180B1.5060302@redhat.com>
Date: Sun, 07 Oct 2012 15:16:33 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1349346964-4151-1-git-send-email-avi@redhat.com>
	<CAFEAcA--j+Od8-4+SeoVUZsENn41o2eRe9KYYGveSzNtZTpuew@mail.gmail.com>
In-Reply-To: <CAFEAcA--j+Od8-4+SeoVUZsENn41o2eRe9KYYGveSzNtZTpuew@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits
	unconditionally
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jia Liu <proljc@gmail.com>, qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Michael Walle <michael@walle.cc>, Paul Brook <paul@codesourcery.com>, Anthony Liguori <anthony@codemonkey.ws>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>

On 10/05/2012 06:45 PM, Peter Maydell wrote:
> On 4 October 2012 11:36, Avi Kivity <avi@redhat.com> wrote:
>> diff --git a/targphys.h b/targphys.h
>> index bd4938f..08cade9 100644
>> --- a/targphys.h
>> +++ b/targphys.h
>> @@ -3,25 +3,10 @@
>>  #ifndef TARGPHYS_H
>>  #define TARGPHYS_H
>>
>> -#ifdef TARGET_PHYS_ADDR_BITS
>> +#define TARGET_PHYS_ADDR_BITS 64
>>  /* target_phys_addr_t is the type of a physical address (its size can
>>     be different from 'target_ulong').  */
> 
> I've just noticed that this change means that linux-user binaries
> now get a definition of target_phys_addr_t (where previously they
> did not get that type at all). Was this intentional, 

No.

> and does it make sense?

Not much.  Not very harmful either.  If you want it removed, I can post
a patch.

-- 
error compiling committee.c: too many arguments to function