From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TL9E7-0006Gp-I2 for qemu-devel@nongnu.org; Mon, 08 Oct 2012 05:02:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TL9E1-0004tD-KS for qemu-devel@nongnu.org; Mon, 08 Oct 2012 05:02:15 -0400 Received: from citadel.icyb.net.ua ([212.40.38.140]:1041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TL9E1-0004t3-9f for qemu-devel@nongnu.org; Mon, 08 Oct 2012 05:02:09 -0400 Message-ID: <5072968C.60000@FreeBSD.org> Date: Mon, 08 Oct 2012 12:02:04 +0300 From: Andriy Gapon MIME-Version: 1.0 References: <50720C75.30109@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org on 08/10/2012 10:52 malc said the following: > On Mon, 8 Oct 2012, Andriy Gapon wrote: > >> >> I am running Qemu (plain, no kvm, etc) on an AMD 10h machine that >> provides popcnt instruction. Qemu advertises availability of pocnt >> to a guest as well. What I see in the guest that popcnt >> 0x20(%r12),%r8 instruction actually placed its result into %rax. >> With %rdi and %rax operands the instruction worked fine though. >> >> > > Does following work? It does! Thank you very much. > diff --git a/target-i386/translate.c b/target-i386/translate.c > index e896abf..c36cc3e 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -7818,7 +7818,7 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start) > goto illegal_op; > > modrm = cpu_ldub_code(cpu_single_env, s->pc++); > - reg = ((modrm >> 3) & 7); > + reg = ((modrm >> 3) & 7) | rex_r; > > if (s->prefix & PREFIX_DATA) > ot = OT_WORD; > -- Andriy Gapon