From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] versatile: Push lsi initialization to the end
Date: Mon, 08 Oct 2012 18:28:02 +0200 [thread overview]
Message-ID: <5072FF12.3020201@redhat.com> (raw)
In-Reply-To: <CAFEAcA8RHbcLSp6wL47BZ95QkCJZz1Ys1vNGnmBHyH9dCtbeuA@mail.gmail.com>
Il 08/10/2012 18:02, Peter Maydell ha scritto:
>> > It's not (only) about a missing event for the serial frontend, it's also
>> > about a spurious open event to the monitor. That generates unwanted
>> > output during startup.
> Right, so whatever's sending that event needs not to do so until
> creation of the machine is complete. Sending events randomly
> halfway through init is a recipe for problems...
So we now have proof that using bottom halves outside the block layer
was a bad idea. Thanks Jan. :)
If Stefan goes on with the AioContext idea, we can have separate
AioContexts for qemu_bh_new on one side and for block devices on the
other, so that qemu_bh_new bottom halves won't fire just because
something is calling the block layer.
In the meanwhile, qemu_char could use a QEMUTimer expiring in the past
instead of a bottom half.
Paolo
next prev parent reply other threads:[~2012-10-08 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 17:30 [Qemu-devel] [PATCH] versatile: Push lsi initialization to the end Jan Kiszka
2012-10-05 17:42 ` Peter Maydell
2012-10-05 18:01 ` Jan Kiszka
2012-10-06 2:13 ` Peter Maydell
2012-10-08 6:52 ` Jan Kiszka
2012-10-08 15:18 ` Paolo Bonzini
2012-10-08 15:28 ` Jan Kiszka
2012-10-08 16:02 ` Peter Maydell
2012-10-08 16:28 ` Paolo Bonzini [this message]
2012-10-08 16:46 ` Jan Kiszka
2012-10-08 17:07 ` Aurelien Jarno
2012-10-08 17:09 ` Jan Kiszka
2012-10-08 16:33 ` Peter Maydell
2012-10-08 16:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5072FF12.3020201@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).