From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLLg1-0007iQ-3t for qemu-devel@nongnu.org; Mon, 08 Oct 2012 18:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLLg0-0007KI-3O for qemu-devel@nongnu.org; Mon, 08 Oct 2012 18:19:53 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:41616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLLfz-0007K3-TE for qemu-devel@nongnu.org; Mon, 08 Oct 2012 18:19:52 -0400 Received: by mail-da0-f45.google.com with SMTP id n15so1791287dad.4 for ; Mon, 08 Oct 2012 15:19:50 -0700 (PDT) Sender: Richard Henderson Message-ID: <50735184.10803@twiddle.net> Date: Mon, 08 Oct 2012 15:19:48 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349729149-6481-1-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1349729149-6481-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org On 10/08/2012 01:45 PM, Michael Roth wrote: > /* Alpha and SH4 user mode emulations and Softmmu call GETPC(). > For all others, GETPC remains undefined (which makes TCI a little faster. */ > -# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) > +# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) \ > + || defined(TARGET_SPARC) > extern uintptr_t tci_tb_ptr; > # define GETPC() tci_tb_ptr Why is this conditional? All targets probably ought to be using it when raising runtime exceptions -- particularly fp exceptions. r~