From: Stefan Weil <sw@weilnetz.de>
To: Richard Henderson <rth@twiddle.net>
Cc: blauwirbel@gmail.com, Michael Roth <mdroth@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc
Date: Tue, 09 Oct 2012 07:22:33 +0200 [thread overview]
Message-ID: <5073B499.7010905@weilnetz.de> (raw)
In-Reply-To: <50735184.10803@twiddle.net>
Am 09.10.2012 00:19, schrieb Richard Henderson:
> On 10/08/2012 01:45 PM, Michael Roth wrote:
>> /* Alpha and SH4 user mode emulations and Softmmu call GETPC().
>> For all others, GETPC remains undefined (which makes TCI a little faster. */
>> -# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4)
>> +# if defined(CONFIG_SOFTMMU) || defined(TARGET_ALPHA) || defined(TARGET_SH4) \
>> + || defined(TARGET_SPARC)
>> extern uintptr_t tci_tb_ptr;
>> # define GETPC() tci_tb_ptr
> Why is this conditional? All targets probably ought to be using it
> when raising runtime exceptions -- particularly fp exceptions.
>
>
> r~
>
See the comment: "which makes TCI a little faster".
When GETPC is undefined, tci.c saves an assignment
to a global variable per interpreted TCG code
which is a significant reduction.
Maybe there are better solutions, of course.
Regards
Stefan
next prev parent reply other threads:[~2012-10-09 5:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 20:45 [Qemu-devel] [PATCH] tci: fix build breakage for target-sparc Michael Roth
2012-10-08 21:03 ` Stefan Weil
2012-10-08 22:19 ` Richard Henderson
2012-10-09 5:22 ` Stefan Weil [this message]
2012-10-19 19:32 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073B499.7010905@weilnetz.de \
--to=sw@weilnetz.de \
--cc=blauwirbel@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).