From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUPX-0003fx-Sa for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:39:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLUPT-0008A3-MZ for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:39:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUPT-00089z-Ee for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:39:23 -0400 Message-ID: <5073D4A0.3060004@redhat.com> Date: Tue, 09 Oct 2012 09:39:12 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <14b2e6e2624751503885092432323e231bd33597.1349749915.git.jbaron@redhat.com> In-Reply-To: <14b2e6e2624751503885092432323e231bd33597.1349749915.git.jbaron@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 04/21] pci: introduce pci_swizzle_map_irq_fn() for standardized interrupt pin swizzle List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Isaku Yamahata > > Introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is > standardized. PCI bridge swizzle is common logic, by introducing > this function duplicated swizzle logic will be avoided later. > > [jbaron@redhat.com: drop opaque argument] > Signed-off-by: Isaku Yamahata > Signed-off-by: Jason Baron Reviewed-by: Paolo Bonzini > --- > hw/pci.c | 18 ++++++++++++++++++ > hw/pci.h | 2 ++ > 2 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/hw/pci.c b/hw/pci.c > index 85ebef6..c457d50 100644 > --- a/hw/pci.c > +++ b/hw/pci.c > @@ -1121,6 +1121,24 @@ void pci_device_set_intx_routing_notifier(PCIDevice *dev, > dev->intx_routing_notifier = notifier; > } > > +/* > + * PCI-to-PCI bridge specification > + * 9.1: Interrupt routing. Table 9-1 > + * > + * the PCI Express Base Specification, Revision 2.1 > + * 2.2.8.1: INTx interrutp signaling - Rules > + * the Implementation Note > + * Table 2-20 > + */ > +/* > + * 0 <= pin <= 3 0 = INTA, 1 = INTB, 2 = INTC, 3 = INTD > + * 0-origin unlike PCI interrupt pin register. > + */ > +int pci_swizzle_map_irq_fn(PCIDevice *pci_dev, int pin) > +{ > + return (pin + PCI_SLOT(pci_dev->devfn)) % PCI_NUM_PINS; > +} > + > /***********************************************************/ > /* monitor info on PCI */ > > diff --git a/hw/pci.h b/hw/pci.h > index 4b6ab3d..397477e 100644 > --- a/hw/pci.h > +++ b/hw/pci.h > @@ -316,6 +316,8 @@ void pci_bus_irqs(PCIBus *bus, pci_set_irq_fn set_irq, pci_map_irq_fn map_irq, > void *irq_opaque, int nirq); > int pci_bus_get_irq_level(PCIBus *bus, int irq_num); > void pci_bus_hotplug(PCIBus *bus, pci_hotplug_fn hotplug, DeviceState *dev); > +/* 0 <= pin <= 3 0 = INTA, 1 = INTB, 2 = INTC, 3 = INTD */ > +int pci_swizzle_map_irq_fn(PCIDevice *pci_dev, int pin); > PCIBus *pci_register_bus(DeviceState *parent, const char *name, > pci_set_irq_fn set_irq, pci_map_irq_fn map_irq, > void *irq_opaque, >