From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUcL-0002Rv-J0 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:52:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLUcH-0004Kr-7B for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:52:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUcG-0004Kn-Up for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:52:37 -0400 Message-ID: <5073D7BA.6000900@redhat.com> Date: Tue, 09 Oct 2012 09:52:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <618a00cbfe7f3d7eea937c4adeeaea39f6fe7cdc.1349749915.git.jbaron@redhat.com> In-Reply-To: <618a00cbfe7f3d7eea937c4adeeaea39f6fe7cdc.1349749915.git.jbaron@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/21] pcie: pass pcie window size to pcie_host_mmcfg_update() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Jason Baron > > This allows q35 to pass/set the size of the pcie window in its update routine. > > Signed-off-by: Jason Baron > --- > hw/pcie_host.c | 21 ++++++++++++--------- > hw/pcie_host.h | 8 +++++--- > 2 files changed, 17 insertions(+), 12 deletions(-) > > diff --git a/hw/pcie_host.c b/hw/pcie_host.c > index 28bbe72..e2fd276 100644 > --- a/hw/pcie_host.c > +++ b/hw/pcie_host.c > @@ -107,14 +107,9 @@ static const MemoryRegionOps pcie_mmcfg_ops = { > /* pcie_host::base_addr == PCIE_BASE_ADDR_UNMAPPED when it isn't mapped. */ > #define PCIE_BASE_ADDR_UNMAPPED ((target_phys_addr_t)-1ULL) > > -int pcie_host_init(PCIExpressHost *e, uint32_t size) > +int pcie_host_init(PCIExpressHost *e) > { > - assert(!(size & (size - 1))); /* power of 2 */ > - assert(size >= PCIE_MMCFG_SIZE_MIN); > - assert(size <= PCIE_MMCFG_SIZE_MAX); > e->base_addr = PCIE_BASE_ADDR_UNMAPPED; > - e->size = size; > - memory_region_init_io(&e->mmio, &pcie_mmcfg_ops, e, "pcie-mmcfg", e->size); > > return 0; > } > @@ -123,22 +118,30 @@ void pcie_host_mmcfg_unmap(PCIExpressHost *e) > { > if (e->base_addr != PCIE_BASE_ADDR_UNMAPPED) { > memory_region_del_subregion(get_system_memory(), &e->mmio); > + memory_region_destroy(&e->mmio); > e->base_addr = PCIE_BASE_ADDR_UNMAPPED; > } > } > > -void pcie_host_mmcfg_map(PCIExpressHost *e, target_phys_addr_t addr) > +void pcie_host_mmcfg_map(PCIExpressHost *e, target_phys_addr_t addr, > + uint32_t size) > { > + assert(!(size & (size - 1))); /* power of 2 */ > + assert(size >= PCIE_MMCFG_SIZE_MIN); > + assert(size <= PCIE_MMCFG_SIZE_MAX); > + e->size = size; > + memory_region_init_io(&e->mmio, &pcie_mmcfg_ops, e, "pcie-mmcfg", e->size); > e->base_addr = addr; > memory_region_add_subregion(get_system_memory(), e->base_addr, &e->mmio); > } > > void pcie_host_mmcfg_update(PCIExpressHost *e, > int enable, > - target_phys_addr_t addr) > + target_phys_addr_t addr, > + uint32_t size) > { > pcie_host_mmcfg_unmap(e); > if (enable) { > - pcie_host_mmcfg_map(e, addr); > + pcie_host_mmcfg_map(e, addr, size); > } > } > diff --git a/hw/pcie_host.h b/hw/pcie_host.h > index 0074508..2faa54e 100644 > --- a/hw/pcie_host.h > +++ b/hw/pcie_host.h > @@ -39,11 +39,13 @@ struct PCIExpressHost { > MemoryRegion mmio; > }; > > -int pcie_host_init(PCIExpressHost *e, uint32_t size); > +int pcie_host_init(PCIExpressHost *e); > void pcie_host_mmcfg_unmap(PCIExpressHost *e); > -void pcie_host_mmcfg_map(PCIExpressHost *e, target_phys_addr_t addr); > +void pcie_host_mmcfg_map(PCIExpressHost *e, target_phys_addr_t addr, > + uint32_t size); These two functions perhaps could be made static, but it can be done in a separate patch. Reviewed-by: Paolo Bonzini > void pcie_host_mmcfg_update(PCIExpressHost *e, > int enable, > - target_phys_addr_t addr); > + target_phys_addr_t addr, > + uint32_t size); > > #endif /* PCIE_HOST_H */ >