From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUcq-0003Ag-0O for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLUck-0004N3-20 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:53:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUcj-0004Mw-On for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:53:05 -0400 Message-ID: <5073D7D8.5070201@redhat.com> Date: Tue, 09 Oct 2012 09:52:56 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <05ae1bad7d67e30a53a6a1bfc3cf2f20abeb50aa.1349749915.git.jbaron@redhat.com> In-Reply-To: <05ae1bad7d67e30a53a6a1bfc3cf2f20abeb50aa.1349749915.git.jbaron@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 11/21] pcie: Convert PCIExpressHost to use the QOM. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Jason Baron >=20 > Let's use PCIExpressHost with QOM. >=20 > Acked-by: Andreas F=C3=A4rber > Signed-off-by: Jason Baron > --- > hw/pcie_host.c | 14 ++++++++++++++ > hw/pcie_host.h | 4 ++++ > 2 files changed, 18 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/pcie_host.c b/hw/pcie_host.c > index e2fd276..027ba05 100644 > --- a/hw/pcie_host.c > +++ b/hw/pcie_host.c > @@ -145,3 +145,17 @@ void pcie_host_mmcfg_update(PCIExpressHost *e, > pcie_host_mmcfg_map(e, addr, size); > } > } > + > +static const TypeInfo pcie_host_type_info =3D { > + .name =3D TYPE_PCIE_HOST_BRIDGE, > + .parent =3D TYPE_PCI_HOST_BRIDGE, > + .abstract =3D true, > + .instance_size =3D sizeof(PCIExpressHost), > +}; > + > +static void pcie_host_register_types(void) > +{ > + type_register_static(&pcie_host_type_info); > +} > + > +type_init(pcie_host_register_types) > diff --git a/hw/pcie_host.h b/hw/pcie_host.h > index 2faa54e..2494c71 100644 > --- a/hw/pcie_host.h > +++ b/hw/pcie_host.h > @@ -24,6 +24,10 @@ > #include "pci_host.h" > #include "memory.h" > =20 > +#define TYPE_PCIE_HOST_BRIDGE "pcie-host-bridge" > +#define PCIE_HOST_BRIDGE(obj) \ > + OBJECT_CHECK(PCIExpressHost, (obj), TYPE_PCIE_HOST_BRIDGE) > + > struct PCIExpressHost { > PCIHostState pci; > =20 >=20 Reviewed-by: Paolo Bonzini Paolo