From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUeJ-0005V3-Or for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLUeD-0004p8-Oc for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:54:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLUeD-0004p4-Ex for qemu-devel@nongnu.org; Tue, 09 Oct 2012 03:54:37 -0400 Message-ID: <5073D833.1070203@redhat.com> Date: Tue, 09 Oct 2012 09:54:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <092c0acd50dc7d66ec0d46277e2fec207c41ffdf.1349749915.git.jbaron@redhat.com> In-Reply-To: <092c0acd50dc7d66ec0d46277e2fec207c41ffdf.1349749915.git.jbaron@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 16/21] q35: smbus: Remove PCI_STATUS_SIG_SYSTEM_ERROR and PCI_STATUS_DETECTED_PARITY from w1cmask List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 09/10/2012 05:30, Jason Baron ha scritto: > From: Jan Kiszka > > Both bits are added to the write-1-to-clear mask by default. As the > smbus device does not allow writes at all, we have to remove it from > that mask, also to avoid triggering a runtime assertion. > > Signed-off-by: Jan Kiszka > Signed-off-by: Jason Baron > --- > hw/q35_smbus.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/hw/q35_smbus.c b/hw/q35_smbus.c > index 5efbe6c..dd64aa2 100644 > --- a/hw/q35_smbus.c > +++ b/hw/q35_smbus.c > @@ -97,6 +97,10 @@ static int ich9_smbus_initfn(PCIDevice *d) > > pci_set_word(d->wmask + PCI_STATUS, > PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY); > + pci_set_word(d->w1cmask + PCI_STATUS, > + pci_get_word(d->w1cmask + PCI_STATUS) & > + ~(PCI_STATUS_SIG_SYSTEM_ERROR | PCI_STATUS_DETECTED_PARITY)); > + > /* TODO? D31IP.SMIP in chipset configuration space */ > pci_config_set_interrupt_pin(d->config, 0x01); /* interrupt pin 1 */ > > Reviewed-by: Paolo Bonzini