From: Alexander Graf <agraf@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] target-ppc: Extend FPU state for newer POWER CPUs
Date: Tue, 09 Oct 2012 17:03:33 +0200 [thread overview]
Message-ID: <50743CC5.9020102@suse.de> (raw)
In-Reply-To: <20121009125033.GC5798@truffula.fritz.box>
On 10/09/2012 02:50 PM, David Gibson wrote:
> On Tue, Oct 09, 2012 at 01:41:02PM +0200, Alexander Graf wrote:
>> On 09.10.2012, at 13:38, Alexander Graf wrote:
>>> On 09.10.2012, at 06:17, David Gibson wrote:
> [snip]
>>> This will still break TCG for qemu-system-ppc64, no?
>> To be more precise:
>>
>> agraf@lychee:/home/agraf/release/qemu> grep -R cpu_fpscr target-ppc
>> target-ppc/translate.c:static TCGv_i32 cpu_fpscr;
> I did update the type of cpu_fpscr..
>
>> target-ppc/translate.c: cpu_fpscr = tcg_global_mem_new_i32(TCG_AREG0,
>> target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[crfD(ctx->opcode)], cpu_fpscr, bfa);
>> target-ppc/translate.c: tcg_gen_andi_i32(cpu_fpscr, cpu_fpscr, ~(0xF<< bfa));
>> target-ppc/translate.c: tcg_gen_extu_i32_i64(cpu_fpr[rD(ctx->opcode)], cpu_fpscr);
>> target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c: tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>>
>> All those functions assume cpu_fpscr is a TCGv32. They need to be
>> adjusted to work on tl instead.
> But I didn't spot the type dependent calls. I figured type checking
> would catch that sort of thing, but apparently not.
Type checking only happens with enable-tcg-debug :)
Alex
next prev parent reply other threads:[~2012-10-09 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 4:17 [Qemu-devel] [0/4] Pending ppc and pseries patches David Gibson
2012-10-09 4:17 ` [Qemu-devel] [PATCH 1/4] pseries: Don't allow duplicate registration of hcalls or RTAS calls David Gibson
2012-10-09 4:17 ` [Qemu-devel] [PATCH 2/4] target-ppc: Extend FPU state for newer POWER CPUs David Gibson
2012-10-09 11:38 ` Alexander Graf
2012-10-09 11:41 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-10-09 12:50 ` David Gibson
2012-10-09 15:03 ` Alexander Graf [this message]
2012-10-09 4:17 ` [Qemu-devel] [PATCH 3/4] target-ppc: Rework storage of VPA registration state David Gibson
2012-10-09 4:17 ` [Qemu-devel] [PATCH 4/4] pseries: Implement qemu initiated shutdowns using EPOW events David Gibson
2012-10-13 8:39 ` Blue Swirl
2012-10-09 11:44 ` [Qemu-devel] [0/4] Pending ppc and pseries patches Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50743CC5.9020102@suse.de \
--to=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).