From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45857)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TLbLU-0002aW-02
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:03:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TLbLO-0005nV-0B
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:03:43 -0400
Message-ID: <50743CC5.9020102@suse.de>
Date: Tue, 09 Oct 2012 17:03:33 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1349756259-12975-1-git-send-email-david@gibson.dropbear.id.au>
	<1349756259-12975-3-git-send-email-david@gibson.dropbear.id.au>
	<DB5AB956-32DE-4F62-81FD-A0E513F2DF44@suse.de>
	<ED179862-AD67-45AA-8DBB-DA0A00546311@suse.de>
	<20121009125033.GC5798@truffula.fritz.box>
In-Reply-To: <20121009125033.GC5798@truffula.fritz.box>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] target-ppc: Extend FPU
 state for newer POWER CPUs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 10/09/2012 02:50 PM, David Gibson wrote:
> On Tue, Oct 09, 2012 at 01:41:02PM +0200, Alexander Graf wrote:
>> On 09.10.2012, at 13:38, Alexander Graf wrote:
>>> On 09.10.2012, at 06:17, David Gibson wrote:
> [snip]
>>> This will still break TCG for qemu-system-ppc64, no?
>> To be more precise:
>>
>> agraf@lychee:/home/agraf/release/qemu>  grep -R cpu_fpscr target-ppc
>> target-ppc/translate.c:static TCGv_i32 cpu_fpscr;
> I did update the type of cpu_fpscr..
>
>> target-ppc/translate.c:    cpu_fpscr = tcg_global_mem_new_i32(TCG_AREG0,
>> target-ppc/translate.c:    tcg_gen_shri_i32(cpu_crf[crfD(ctx->opcode)], cpu_fpscr, bfa);
>> target-ppc/translate.c:    tcg_gen_andi_i32(cpu_fpscr, cpu_fpscr, ~(0xF<<  bfa));
>> target-ppc/translate.c:    tcg_gen_extu_i32_i64(cpu_fpr[rD(ctx->opcode)], cpu_fpscr);
>> target-ppc/translate.c:        tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c:        tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c:        tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>> target-ppc/translate.c:        tcg_gen_shri_i32(cpu_crf[1], cpu_fpscr, FPSCR_OX);
>>
>> All those functions assume cpu_fpscr is a TCGv32. They need to be
>> adjusted to work on tl instead.
> But I didn't spot the type dependent calls.  I figured type checking
> would catch that sort of thing, but apparently not.

Type checking only happens with enable-tcg-debug :)


Alex