From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLbpC-000330-77
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:35:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLboI-0000Rh-Qp
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:34:26 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:33263)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLboI-0000R8-JW
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 11:33:30 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp2so5342493pbb.4
	for <qemu-devel@nongnu.org>; Tue, 09 Oct 2012 08:33:29 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <507443C8.5020303@twiddle.net>
Date: Tue, 09 Oct 2012 08:33:28 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1349202750-16815-1-git-send-email-rth@twiddle.net>
	<1349202750-16815-5-git-send-email-rth@twiddle.net>
	<20121009152506.GE14078@ohm.aurel32.net>
In-Reply-To: <20121009152506.GE14078@ohm.aurel32.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/10] tcg: Use common code when failing to
 optimize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 10/09/2012 08:25 AM, Aurelien Jarno wrote:
>> > @@ -639,6 +639,7 @@ static TCGArg *tcg_constant_folding(TCGContext *s, uint16_t *tcg_opc_ptr,
>> >              gen_args += 2;
>> >              args += 2;
>> >              break;
>> > +
> Why this new line?
> 

After the patch, all of the CASE blocks have a separator line.
It looked weird to have that be true of all but one case block
within that switch.


r~