From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TLcuW-00066b-0i
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:44:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TLcuQ-0007hs-6d
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:43:59 -0400
Received: from hub021-nj-4.exch021.serverdata.net ([206.225.164.219]:19246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TLcuQ-0007hl-33
	for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:43:54 -0400
Message-ID: <50745448.2060501@CloudSwitch.Com>
Date: Tue, 9 Oct 2012 12:43:52 -0400
From: Don Slutz <Don@CloudSwitch.Com>
MIME-Version: 1.0
References: <1349791439-15369-1-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1349791439-15369-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [QEMU PATCH] i386: cpu: add missing CPUID[EAX=7,
 ECX=0] flag names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: jinsong.liu@intel.com, kvm@vger.kernel.org, wei.y.yang@intel.com, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, donald.d.dugger@intel.com, junjie.mao@intel.com, Igor Mammedov <imammedo@redhat.com>

On 10/09/12 10:03, Eduardo Habkost wrote:
> This makes QEMU recognize the following CPU flag names:
>
>   Flags            | Corresponding KVM kernel commit
>   -----------------+----------------------------------------
>   FSGSBASE         | 176f61da82435eae09cc96f70b530d1ba0746b8b
>   AVX2, BMI1, BMI2 | fb215366b3c7320ac25dca766a0152df16534932
>   HLE, RTM         | 83c529151ab0d4a813e3f6a3e293fff75d468519
>   INVPCID          | ad756a1603c5fac207758faaac7f01c34c9d0b7b
>   ERMS             | a01c8f9b4e266df1d7166d23216f2060648f862d
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>   target-i386/cpu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index f3708e6..b012372 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -105,8 +105,8 @@ static const char *svm_feature_name[] = {
>   };
>   
>   static const char *cpuid_7_0_ebx_feature_name[] = {
> -    NULL, NULL, NULL, NULL, NULL, NULL, NULL, "smep",
> -    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> +    "fsgsbase", NULL, NULL, "bmi1", "hle", "avx2", NULL, "smep",
> +    "bmi2", "erms", "invpcid", "rtm", NULL, NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, "smap", NULL, NULL, NULL,
>       NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
>   };
Reviewed-by: Don Slutz <Don@CloudSwitch.com>