From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLd45-0002Fs-To for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLd41-0005AO-W4 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 12:53:53 -0400 Message-ID: <50745695.2060508@redhat.com> Date: Tue, 09 Oct 2012 18:53:41 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349714816-12618-1-git-send-email-Bharat.Bhushan@freescale.com> <1349714816-12618-3-git-send-email-Bharat.Bhushan@freescale.com> <50730BA3.5000005@suse.de> <5073E8AA.8030107@redhat.com> <6A3DF150A5B70D4F9B66A25E3F7C888D064B85C2@039-SN2MPN1-022.039d.mgd.msft.net> In-Reply-To: <6A3DF150A5B70D4F9B66A25E3F7C888D064B85C2@039-SN2MPN1-022.039d.mgd.msft.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] e500: Adding CCSR memory region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bhushan Bharat-R65777 Cc: "qemu-devel@nongnu.org" , "qemu-ppc@nongnu.org" , =?ISO-8859-1?Q?Andreas_F=E4rber?= , "agraf@suse.de" On 10/09/2012 06:45 PM, Bhushan Bharat-R65777 wrote: > > What about adding a API: > void sysbus_mmio_map_to_mr(SysBusDevice *dev, int n, target_phys_addr_t addr, > MemoryRegion *mr) > { > assert(n >= 0 && n < dev->num_mmio); > > if (dev->mmio[n].addr == addr) { > /* ??? region already mapped here. */ > return; > } > if (dev->mmio[n].addr != (target_phys_addr_t)-1) { > /* Unregister previous mapping. */ > memory_region_del_subregion(mr, dev->mmio[n].memory); > } > dev->mmio[n].addr = addr; > memory_region_add_subregion(mr, addr, dev->mmio[n].memory); > } > I think you can just use sysbus_mmio_get_region(). There are plenty of other users, so there's precedent. -- error compiling committee.c: too many arguments to function