From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLf5q-0006mf-RV for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:03:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLf5m-00084m-Nq for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:03:50 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:49537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLf5m-000843-GR for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:03:46 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so5517652pad.4 for ; Tue, 09 Oct 2012 12:03:45 -0700 (PDT) Sender: Richard Henderson Message-ID: <50747510.5010709@twiddle.net> Date: Tue, 09 Oct 2012 12:03:44 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> <1349526621-13939-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1349526621-13939-7-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/14] i386: factor gen_op_set_cc_op/tcg_gen_discard_tl around computing flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 10/06/2012 05:30 AM, Paolo Bonzini wrote: > Before computing flags we need to store the cc_op to memory. Move this > to gen_compute_eflags_c and gen_compute_eflags rather than doing it all > over the place. > > Alo, after computing the flags in cpu_cc_src we are in EFLAGS mode. > Set s->cc_op and discard cpu_cc_dst in gen_compute_eflags, rather than > doing it all over the place. > > Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson r~