From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLfI5-0000Ts-IO for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:16:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLfHz-0007Ao-RT for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:16:29 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:52908) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLfHz-0007Ag-K1 for qemu-devel@nongnu.org; Tue, 09 Oct 2012 15:16:23 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so5591062pbb.4 for ; Tue, 09 Oct 2012 12:16:23 -0700 (PDT) Sender: Richard Henderson Message-ID: <50747805.3090102@twiddle.net> Date: Tue, 09 Oct 2012 12:16:21 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> <1349526621-13939-10-git-send-email-pbonzini@redhat.com> In-Reply-To: <1349526621-13939-10-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute ZF/SF List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 10/06/2012 05:30 AM, Paolo Bonzini wrote: > + int size = (s->cc_op - CC_OP_ADDB) & 3; > + gen_ext_tl(reg, cpu_cc_dst, size, false); > + tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0); I take that back. Should be (EQ, reg, reg, 0) here; you've dropped the extension on the floor. r~