From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgB0-0001ZH-RY for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:13:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLgAz-000566-Qc for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:13:14 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:47892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLgAz-000562-JI for qemu-devel@nongnu.org; Tue, 09 Oct 2012 16:13:13 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so5588684pad.4 for ; Tue, 09 Oct 2012 13:13:13 -0700 (PDT) Sender: Richard Henderson Message-ID: <50748557.4000602@twiddle.net> Date: Tue, 09 Oct 2012 13:13:11 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com> <1349526621-13939-14-git-send-email-pbonzini@redhat.com> In-Reply-To: <1349526621-13939-14-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/14] i386: optimize setbe List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 10/06/2012 05:30 AM, Paolo Bonzini wrote: > gen_compute_eflags(s); > - tcg_gen_shri_tl(reg, cpu_cc_src, 6); > - tcg_gen_or_tl(reg, reg, cpu_cc_src); > - tcg_gen_andi_tl(reg, reg, 1); > - break; > + tcg_gen_andi_tl(reg, cpu_cc_src, 0x41); > + tcg_gen_setcondi_tl(inv ? TCG_COND_EQ : TCG_COND_NE, reg, reg, 0); > + return; This one's questionable. Whether it's an improvement really depends on the host cpu isa. It's probably more of a benefit if we can avoid the setcond completely. See the comments for the next patch. That said, the patch produces correct code. Reviewed-by: Richard Henderson r~