From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TLq0I-0007Dx-Rx
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 02:42:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TLq0I-0003xG-0Q
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 02:42:50 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:50883)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TLq0H-0003x3-PW
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 02:42:49 -0400
Received: by mail-wi0-f175.google.com with SMTP id hq4so4897571wib.10
	for <qemu-devel@nongnu.org>; Tue, 09 Oct 2012 23:42:49 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <507518E7.6030506@redhat.com>
Date: Wed, 10 Oct 2012 08:42:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349526621-13939-1-git-send-email-pbonzini@redhat.com>
	<1349526621-13939-10-git-send-email-pbonzini@redhat.com>
	<50747805.3090102@twiddle.net>
In-Reply-To: <50747805.3090102@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/14] i386: do not call helper to compute
	ZF/SF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

Il 09/10/2012 21:16, Richard Henderson ha scritto:
>> > +        int size = (s->cc_op - CC_OP_ADDB) & 3;
>> > +        gen_ext_tl(reg, cpu_cc_dst, size, false);
>> > +        tcg_gen_setcondi_tl(TCG_COND_EQ, reg, cpu_cc_dst, 0);
> I take that back.  Should be (EQ, reg, reg, 0) here;
> you've dropped the extension on the floor.

More precisely it should be:

        TCGv t0 = gen_ext_tl(reg, cpu_cc_dst, size, false);
        tcg_gen_setcondi_tl(TCG_COND_EQ, reg, t0, 0);

and similarly for SF.

Paolo