[Qemu-devel] Compile error

[Qemu-devel] Compile error

[Gerhard Wiesinger]

Hello,

qemu is currently not compile clean on Fedora 17:

CC fsdev/virtfs-proxy-helper.o
fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of 
‘setfsgid’, declared with attribute warn_unused_result 
[-Werror=unused-result]
fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of 
‘setfsuid’, declared with attribute warn_unused_result 
[-Werror=unused-result]
cc1: all warnings being treated as errors
make: *** [fsdev/virtfs-proxy-helper.o] Error 1

gcc --version
gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)

Please fix it.

Ciao,
Gerhard

Re: [Qemu-devel] Compile error

[Gerhard Wiesinger]

Hello,

Still not compile clean, also on the build servers. Who is responsible 
for the fix?

Ciao,
Gerhard

On 16.09.2012 18:25, Gerhard Wiesinger wrote:
> Hello,
>
> qemu is currently not compile clean on Fedora 17:
>
> CC fsdev/virtfs-proxy-helper.o
> fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
> fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of 
> ‘setfsgid’, declared with attribute warn_unused_result 
> [-Werror=unused-result]
> fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of 
> ‘setfsuid’, declared with attribute warn_unused_result 
> [-Werror=unused-result]
> cc1: all warnings being treated as errors
> make: *** [fsdev/virtfs-proxy-helper.o] Error 1
>
> gcc --version
> gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
>
> Please fix it.
>
> Ciao,
> Gerhard
>
>

[Qemu-devel] Wrong license (GPL 2 only) for files in fsdev

[Stefan Weil]

Hi,

all files in fsdev still use GNU GPL version 2 only instead of
GNU GPL  version 2 or later.

Can this be fixed? If not, we should addtext like this:

* Contributions after 2012-10-10 are licensed under the terms of the
* GNU GPL, version 2 or (at your option) any later version.

Is it possible to add some general statement to the QEMU license
so that any file which is newly added and which uses GPL 2 is
automatically GPL 2+? IMHO at least some remarks in CODING_STYLE
would be good.

Regards

Stefan Weil

Re: [Qemu-devel] Wrong license (GPL 2 only) for files in fsdev

[Paolo Bonzini]

Il 10/10/2012 07:52, Stefan Weil ha scritto:
> Hi,
> 
> all files in fsdev still use GNU GPL version 2 only instead of
> GNU GPL  version 2 or later.

It's IBM copyright, so I think no.

> Can this be fixed? If not, we should addtext like this:
> 
> * Contributions after 2012-10-10 are licensed under the terms of the
> * GNU GPL, version 2 or (at your option) any later version.

Yes, that would be good.

> Is it possible to add some general statement to the QEMU license
> so that any file which is newly added and which uses GPL 2 is
> automatically GPL 2+? IMHO at least some remarks in CODING_STYLE
> would be good.

No, because in some cases there is GPLv2 code in the file, as was the
case for PCI device assignment.

Paolo

Re: [Qemu-devel] Compile error

[Gerhard Wiesinger]

Ping again ...

Ciao,
Gerhard

On 10.10.2012 07:17, Gerhard Wiesinger wrote:
> Hello,
>
> Still not compile clean, also on the build servers. Who is responsible 
> for the fix?
>
> Ciao,
> Gerhard
>
> On 16.09.2012 18:25, Gerhard Wiesinger wrote:
>> Hello,
>>
>> qemu is currently not compile clean on Fedora 17:
>>
>> CC fsdev/virtfs-proxy-helper.o
>> fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
>> fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of 
>> ‘setfsgid’, declared with attribute warn_unused_result 
>> [-Werror=unused-result]
>> fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of 
>> ‘setfsuid’, declared with attribute warn_unused_result 
>> [-Werror=unused-result]
>> cc1: all warnings being treated as errors
>> make: *** [fsdev/virtfs-proxy-helper.o] Error 1
>>
>> gcc --version
>> gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
>>
>> Please fix it.
>>
>> Ciao,
>> Gerhard
>>
>>
>
>
>

Re: [Qemu-devel] Compile error

[Max Filippov]

On Thu, Nov 1, 2012 at 11:47 PM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
> Ping again ...

Can you just configure it with --disable-werror ? IIRC it is the
default for the released
QEMU versions.

> On 10.10.2012 07:17, Gerhard Wiesinger wrote:
>>
>> Hello,
>>
>> Still not compile clean, also on the build servers. Who is responsible for
>> the fix?
>>
>> Ciao,
>> Gerhard
>>
>> On 16.09.2012 18:25, Gerhard Wiesinger wrote:
>>>
>>> Hello,
>>>
>>> qemu is currently not compile clean on Fedora 17:
>>>
>>> CC fsdev/virtfs-proxy-helper.o
>>> fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
>>> fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of
>>> ‘setfsgid’, declared with attribute warn_unused_result
>>> [-Werror=unused-result]
>>> fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of
>>> ‘setfsuid’, declared with attribute warn_unused_result
>>> [-Werror=unused-result]
>>> cc1: all warnings being treated as errors
>>> make: *** [fsdev/virtfs-proxy-helper.o] Error 1
>>>
>>> gcc --version
>>> gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
>>>
>>> Please fix it.

-- 
Thanks.
-- Max

Re: [Qemu-devel] Compile error

[Gerhard Wiesinger]

Hello,

Yes, compiles when warnings are not treated as errors.

But do we want to be only compile clean when we suppress such warnings?

Also ./configure with plattform should be enough.

Ciao,
Gerhard

On 01.11.2012 21:13, Max Filippov wrote:
> On Thu, Nov 1, 2012 at 11:47 PM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
>> Ping again ...
> Can you just configure it with --disable-werror ? IIRC it is the
> default for the released
> QEMU versions.
>
>> On 10.10.2012 07:17, Gerhard Wiesinger wrote:
>>> Hello,
>>>
>>> Still not compile clean, also on the build servers. Who is responsible for
>>> the fix?
>>>
>>> Ciao,
>>> Gerhard
>>>
>>> On 16.09.2012 18:25, Gerhard Wiesinger wrote:
>>>> Hello,
>>>>
>>>> qemu is currently not compile clean on Fedora 17:
>>>>
>>>> CC fsdev/virtfs-proxy-helper.o
>>>> fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
>>>> fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of
>>>> ‘setfsgid’, declared with attribute warn_unused_result
>>>> [-Werror=unused-result]
>>>> fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of
>>>> ‘setfsuid’, declared with attribute warn_unused_result
>>>> [-Werror=unused-result]
>>>> cc1: all warnings being treated as errors
>>>> make: *** [fsdev/virtfs-proxy-helper.o] Error 1
>>>>
>>>> gcc --version
>>>> gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
>>>>
>>>> Please fix it.

Re: [Qemu-devel] Compile error

[Anthony Liguori]

Gerhard Wiesinger <lists@wiesinger.com> writes:

> Ping again ...
>
> Ciao,
> Gerhard

What platform is this breaking on?

Can you point me to the buildbot failure?

Regards,

Anthony Liguori

>
> On 10.10.2012 07:17, Gerhard Wiesinger wrote:
>> Hello,
>>
>> Still not compile clean, also on the build servers. Who is responsible 
>> for the fix?
>>
>> Ciao,
>> Gerhard
>>
>> On 16.09.2012 18:25, Gerhard Wiesinger wrote:
>>> Hello,
>>>
>>> qemu is currently not compile clean on Fedora 17:
>>>
>>> CC fsdev/virtfs-proxy-helper.o
>>> fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
>>> fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of 
>>> ‘setfsgid’, declared with attribute warn_unused_result 
>>> [-Werror=unused-result]
>>> fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of 
>>> ‘setfsuid’, declared with attribute warn_unused_result 
>>> [-Werror=unused-result]
>>> cc1: all warnings being treated as errors
>>> make: *** [fsdev/virtfs-proxy-helper.o] Error 1
>>>
>>> gcc --version
>>> gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)
>>>
>>> Please fix it.
>>>
>>> Ciao,
>>> Gerhard
>>>
>>>
>>
>>
>>

Re: [Qemu-devel] Compile error

[Gerhard Wiesinger]

On 01.11.2012 21:58, Anthony Liguori wrote:
> What platform is this breaking on?
>
> Can you point me to the buildbot failure?

Fedora 17, x64:
3.6.3-1.fc17.x86_64
gcc (GCC) 4.7.2 20120921 (Red Hat 4.7.2-2)

E.g. here:
http://www.kraxel.org/bb/builders/fedora-default/builds/888/steps/compile/logs/stdio

Ciao,
Gerhard