From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLrK3-00056c-1t for qemu-devel@nongnu.org; Wed, 10 Oct 2012 04:07:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLrJt-0005B6-LI for qemu-devel@nongnu.org; Wed, 10 Oct 2012 04:07:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLrJt-0005Av-D2 for qemu-devel@nongnu.org; Wed, 10 Oct 2012 04:07:09 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9A8789D001161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Oct 2012 04:07:08 -0400 Message-ID: <50752CA9.8010802@redhat.com> Date: Wed, 10 Oct 2012 10:07:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <37ca1a150224c144f9329fc8408f78c388f50a02.1349848348.git.jcody@redhat.com> <5075251A.1010509@redhat.com> <50752AD6.4040604@redhat.com> In-Reply-To: <50752AD6.4040604@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: jcody@redhat.com Cc: kwolf@redhat.com, qemu-devel@nongnu.org Il 10/10/2012 09:59, Jeff Cody ha scritto: >> Unfortunately realpath does not exist on Win32. But >> http://lists.gnu.org/archive/html/grub-devel/2011-09/msg00034.html >> suggests that there is a _fullpath and in fact already has all you need >> to write a qemu_realpath function. > > Doesn't block.c already rely on realpath(), in bdrv_open()? Why would > this be any different using it here? Uh, indeed there's already a _fullpath wrapper in qemu-common.h. My bad, I only grepped os*. Reviewed-by: Paolo Bonzini Paolo