From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLzam-0004cv-2S for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:57:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLzag-0002oV-33 for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:57:08 -0400 Received: from mail-da0-f45.google.com ([209.85.210.45]:55755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLzaf-0002oQ-Sx for qemu-devel@nongnu.org; Wed, 10 Oct 2012 12:57:02 -0400 Received: by mail-da0-f45.google.com with SMTP id n15so269550dad.4 for ; Wed, 10 Oct 2012 09:57:01 -0700 (PDT) Sender: Richard Henderson Message-ID: <5075A8DB.6050006@twiddle.net> Date: Wed, 10 Oct 2012 09:56:59 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349812584-19551-1-git-send-email-aurelien@aurel32.net> <1349812584-19551-12-git-send-email-aurelien@aurel32.net> In-Reply-To: <1349812584-19551-12-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 11/26] tcg: fix some op flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 10/09/2012 12:56 PM, Aurelien Jarno wrote: > Some branch related ops are marked with TCG_OPF_SIDE_EFFECTS, some other > not. In practice they don't need to, as they are all marked with > TCG_OPF_BB_END, which is handled specifically in all the code. > > The call op is marked as TCG_OPF_SIDE_EFFECTS, which might be not true > as there is are specific flags (TCG_CALL_CONST and TCG_CALL_PURE) for > specifying that. On the other hand it always clobber arguments, so mark > it as such even if the call op is handled in a different code path. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~