From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49839)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLzpD-00073n-H3
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 13:12:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLzp6-0000Eh-Vs
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 13:12:03 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:52854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TLzp6-0000EP-OQ
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 13:11:56 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp2so922190pbb.4
	for <qemu-devel@nongnu.org>; Wed, 10 Oct 2012 10:11:56 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5075AC5A.6040503@twiddle.net>
Date: Wed, 10 Oct 2012 10:11:54 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1349812584-19551-1-git-send-email-aurelien@aurel32.net>
	<1349812584-19551-15-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1349812584-19551-15-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 14/26] tcg: rework TCG helper flags
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 10/09/2012 12:56 PM, Aurelien Jarno wrote:
> +                    if (!(call_flags & (TCG_CALL_NO_WRITE_GLOBALS |
> +                                        TCG_CALL_NO_READ_GLOBALS))) {

Code like this would be shorter, and perhaps clearer, by

> +/* Helper does not read globals (either directly or through an exception). It
> +   implies TCG_CALL_NO_WRITE_GLOBALS. */
> +#define TCG_CALL_NO_READ_GLOBALS    0x0010
> +/* Helper does not write globals */
> +#define TCG_CALL_NO_WRITE_GLOBALS   0x0020

having RG actually include WG, i.e.

#define TCG_CALL_NO_READ_GLOBALS  0x0030

That said, 

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~