From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TM4Q6-0003zP-1V
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 18:06:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TM4Q0-0006pd-Rj
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 18:06:25 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57726 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TM4Q0-0006p8-M5
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 18:06:20 -0400
Message-ID: <5075D536.9040806@suse.de>
Date: Wed, 10 Oct 2012 22:06:14 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1349898194-27140-1-git-send-email-imammedo@redhat.com>
In-Reply-To: <1349898194-27140-1-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4] target-i386: initialize APIC at CPU
	level
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, Don@CloudSwitch.com, qemu-devel@nongnu.org, lcapitulino@redhat.com

Am 10.10.2012 21:43, schrieb Igor Mammedov:
> (L)APIC is a part of cpu [1] so move APIC initialization inside of
> x86_cpu object. Since cpu_model and override flags currently specify
> whether APIC should be created or not, APIC creation&initialization is
> moved into x86_cpu_apic_init() which is called from x86_cpu_realize().
>=20
> [1] - all x86 cpus have integrated APIC if we overlook existence of i48=
6,
> and it's more convenient to model after majority of them.
>=20
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

Thanks, queued on qom-cpu branch (with error_setg() indentation fixed):
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg