From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM2tm-0001go-0S for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:28:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TM2tk-0005lV-SQ for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:28:57 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:58141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM2tk-0005lN-L5 for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:28:56 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so988165pad.4 for ; Wed, 10 Oct 2012 13:28:55 -0700 (PDT) Sender: Richard Henderson Message-ID: <5075DA86.5030305@twiddle.net> Date: Wed, 10 Oct 2012 13:28:54 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349814458-21739-1-git-send-email-aurelien@aurel32.net> <1349814458-21739-9-git-send-email-aurelien@aurel32.net> In-Reply-To: <1349814458-21739-9-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/14] target-mips: implement unaligned loads using TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 10/09/2012 01:27 PM, Aurelien Jarno wrote: > Load/store from helpers should be avoided as they are quite > inefficient. Rewrite unaligned loads instructions using TCG and > aligned loads. The number of actual loads operations to implement > an unaligned load instruction is reduced from up to 8 to 1. > > Note: As we can't rely on shift by 32 or 64 undefined behaviour, > the code loads already shift by one constants. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~