From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands
Date: Wed, 10 Oct 2012 14:41:05 -0600 [thread overview]
Message-ID: <5075DD61.6060501@redhat.com> (raw)
In-Reply-To: <1349877786-23514-25-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On 10/10/2012 08:03 AM, Paolo Bonzini wrote:
> Adding an NBD server inside QEMU is trivial, since all the logic is
> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
> The main difference is that qemu-nbd serves a single unnamed export,
> while QEMU serves named exports.
>
> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> +##
> +# @nbd-server-add:
> +#
> +# Export a device to QEMU's embedded NBD server.
> +#
> +# @device: Block device to be exported
> +#
> +# @writable: Whether clients should be able to write to the device via the
> +# NBD connection (default false). #optional
Isn't the #optional designation supposed to come first, before 'Whether'?
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-10 20:41 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 14:02 [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 01/25] error: add error_set_errno and error_setg_errno Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 02/25] qemu-sockets: add Error ** to all functions Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 03/25] qemu-sockets: unix_listen and unix_connect are portable Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 04/25] qemu-sockets: add nonblocking connect for Unix sockets Paolo Bonzini
2012-10-17 13:33 ` Markus Armbruster
2012-10-17 13:44 ` Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL Paolo Bonzini
2012-10-17 13:36 ` Markus Armbruster
2012-10-17 13:37 ` Paolo Bonzini
2012-10-17 15:44 ` Markus Armbruster
2012-10-10 14:02 ` [Qemu-devel] [PATCH 06/25] migration: centralize call to migrate_fd_error() Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 07/25] migration: use qemu-sockets to establish Unix sockets Paolo Bonzini
2012-10-17 14:30 ` Markus Armbruster
2012-10-10 14:02 ` [Qemu-devel] [PATCH 08/25] migration (outgoing): add error propagation for all protocols Paolo Bonzini
2012-10-17 14:43 ` Markus Armbruster
2012-10-17 14:50 ` Paolo Bonzini
2012-10-17 15:43 ` Markus Armbruster
2012-10-10 14:02 ` [Qemu-devel] [PATCH 09/25] migration (incoming): add error propagation to fd and exec protocols Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 10/25] qemu-char: ask and print error information from qemu-sockets Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 11/25] nbd: " Paolo Bonzini
2012-10-17 14:51 ` Markus Armbruster
2012-10-17 14:53 ` Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 12/25] qemu-ga: " Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 13/25] vnc: add error propagation to vnc_display_open Paolo Bonzini
2012-10-17 15:17 ` Markus Armbruster
2012-10-17 15:48 ` Paolo Bonzini
2012-10-19 7:49 ` Markus Armbruster
2012-10-19 8:40 ` Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 14/25] qemu-sockets: include strerror or gai_strerror output in error messages Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr Paolo Bonzini
2012-10-16 12:53 ` Luiz Capitulino
2012-10-17 15:40 ` Markus Armbruster
2012-10-17 15:50 ` Paolo Bonzini
2012-10-19 7:59 ` Markus Armbruster
2012-10-19 8:50 ` Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 16/25] qemu-sockets: add error propagation to inet_dgram_opts Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 17/25] qemu-sockets: add error propagation to inet_parse Paolo Bonzini
2012-10-10 14:02 ` [Qemu-devel] [PATCH 18/25] qemu-sockets: add error propagation to Unix socket functions Paolo Bonzini
2012-10-10 14:03 ` [Qemu-devel] [PATCH 19/25] build: add QAPI files to the tools Paolo Bonzini
2012-10-10 14:03 ` [Qemu-devel] [PATCH 20/25] qapi: add socket address types Paolo Bonzini
2012-10-17 16:43 ` Markus Armbruster
2012-10-17 16:48 ` Paolo Bonzini
2012-10-17 16:50 ` Luiz Capitulino
2012-10-19 8:10 ` Markus Armbruster
2012-10-19 8:39 ` Paolo Bonzini
2012-10-10 14:03 ` [Qemu-devel] [PATCH 21/25] qemu-sockets: return IPSocketAddress from inet_parse Paolo Bonzini
2012-10-17 16:49 ` Markus Armbruster
2012-10-10 14:03 ` [Qemu-devel] [PATCH 22/25] qemu-sockets: add socket_listen, socket_connect, socket_parse Paolo Bonzini
2012-10-19 8:15 ` Markus Armbruster
2012-10-19 8:37 ` Paolo Bonzini
2012-10-10 14:03 ` [Qemu-devel] [PATCH 23/25] block: add close notifiers Paolo Bonzini
2012-10-19 8:21 ` Markus Armbruster
2012-10-19 9:38 ` Paolo Bonzini
2012-10-19 8:26 ` Markus Armbruster
2012-10-10 14:03 ` [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands Paolo Bonzini
2012-10-10 20:41 ` Eric Blake [this message]
2012-10-11 13:06 ` Paolo Bonzini
2012-10-11 13:14 ` Eric Blake
2012-10-11 13:22 ` Paolo Bonzini
2012-10-19 8:31 ` Markus Armbruster
2012-10-10 14:03 ` [Qemu-devel] [PATCH 25/25] hmp: " Paolo Bonzini
2012-10-19 8:34 ` Markus Armbruster
2012-10-19 8:58 ` Paolo Bonzini
2012-10-19 12:44 ` Luiz Capitulino
2012-10-19 12:44 ` Markus Armbruster
2012-10-19 13:11 ` Paolo Bonzini
2012-10-19 13:53 ` Markus Armbruster
2012-10-19 13:57 ` Paolo Bonzini
2012-10-16 13:09 ` [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server Luiz Capitulino
2012-10-16 13:10 ` Paolo Bonzini
2012-10-17 17:02 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5075DD61.6060501@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).