From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM35d-00007x-Km for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:41:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TM35Z-0002B2-HJ for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:41:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM35Z-0002Ap-8F for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:41:09 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9AKf6S2020937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Oct 2012 16:41:08 -0400 Message-ID: <5075DD61.6060501@redhat.com> Date: Wed, 10 Oct 2012 14:41:05 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com> <1349877786-23514-25-git-send-email-pbonzini@redhat.com> In-Reply-To: <1349877786-23514-25-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2953DA48028B8CD57DE47E23" Subject: Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2953DA48028B8CD57DE47E23 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/10/2012 08:03 AM, Paolo Bonzini wrote: > Adding an NBD server inside QEMU is trivial, since all the logic is > in nbd.c and can be shared easily between qemu-nbd and QEMU itself. > The main difference is that qemu-nbd serves a single unnamed export, > while QEMU serves named exports. >=20 > Acked-by: Luiz Capitulino > Signed-off-by: Paolo Bonzini > --- > +## > +# @nbd-server-add: > +# > +# Export a device to QEMU's embedded NBD server. > +# > +# @device: Block device to be exported > +# > +# @writable: Whether clients should be able to write to the device via= the > +# NBD connection (default false). #optional Isn't the #optional designation supposed to come first, before 'Whether'?= --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2953DA48028B8CD57DE47E23 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQdd1hAAoJEKeha0olJ0NqwFEH/3K+g1ST7feaDQF2ldHcQz+W DZv/PJNjk69eMfVBo02Vh3ybszXq7PtnDSstNgGfWiTWUxul7M9F88BW6Wr268Mq sOFTjb/1giDWi7PFKHUm2hDbT8/425cLP0omqLx15+bt+dbiI2zHEcb5vMjhJK9T WhcQvZNDZukxeSjl3eXwWkc8XYLSc5M23FmqxFZvB7rHHF1zNNQy6MS0VAwM6/m4 3Zv+8Y1tp+vmKWTgvHLrqqJIpi+z6KdjcQyHHhVW2SZPTL11/YEZfTHd5tL2Ve2u 0QQg/B6Qfy4lHQ8DAlUDqQZ9xd/YwHZp1LaQr+W6HmQdeX5CSisX/ofP8PpvpQU= =PMxu -----END PGP SIGNATURE----- --------------enig2953DA48028B8CD57DE47E23--