From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM37y-00016N-ME for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:43:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TM37u-0002kC-BY for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:43:38 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TM37u-0002k4-4z for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:43:34 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so1099816pbb.4 for ; Wed, 10 Oct 2012 13:43:33 -0700 (PDT) Sender: Richard Henderson Message-ID: <5075DDF3.4040202@twiddle.net> Date: Wed, 10 Oct 2012 13:43:31 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349814458-21739-1-git-send-email-aurelien@aurel32.net> <1349814458-21739-13-git-send-email-aurelien@aurel32.net> In-Reply-To: <1349814458-21739-13-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/14] target-mips: use deposit instead of hardcoded version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 10/09/2012 01:27 PM, Aurelien Jarno wrote: > Use the deposit op instead of and hardcoded bit field insertion. It > allows the host to emit the corresponding instruction if available. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~