From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TM38f-0002CI-Ip
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:44:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TM38e-0002sK-Rd
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:44:21 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:38109)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TM38e-0002s7-Hj
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 16:44:20 -0400
Received: by mail-pb0-f45.google.com with SMTP id rp2so1100361pbb.4
	for <qemu-devel@nongnu.org>; Wed, 10 Oct 2012 13:44:19 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5075DE22.2050506@twiddle.net>
Date: Wed, 10 Oct 2012 13:44:18 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1349814458-21739-1-git-send-email-aurelien@aurel32.net>
	<1349814458-21739-14-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1349814458-21739-14-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 13/14] target-mips: fix TLBR wrt SEGMask
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 10/09/2012 01:27 PM, Aurelien Jarno wrote:
>              tag = env->CP0_EntryHi & ~mask;
>              VPN = tlb->VPN & ~mask;
> +#if defined(TARGET_MIPS64)
> +        tag &= env->SEGMask;
> +#endif
>              /* Check ASID, virtual page number & size */

Indentation.


r~