From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1TM3Ri-00025p-DY
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 17:04:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1TM3Rc-0001Qx-OF
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 17:04:02 -0400
Received: from citadel.icyb.net.ua ([212.40.38.140]:3950)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1TM3Rc-0001Qs-DA
	for qemu-devel@nongnu.org; Wed, 10 Oct 2012 17:03:56 -0400
Message-ID: <5075E2B6.9060603@FreeBSD.org>
Date: Thu, 11 Oct 2012 00:03:50 +0300
From: Andriy Gapon <avg@FreeBSD.org>
MIME-Version: 1.0
References: <50720C75.30109@FreeBSD.org>
	<alpine.LNX.2.00.1210081152040.2993@linmac>
	<5072968C.60000@FreeBSD.org>
In-Reply-To: <5072968C.60000@FreeBSD.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] bug in popcnt emulation with some register
	operand(s)?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>, qemu-devel@nongnu.org

on 08/10/2012 12:02 Andriy Gapon said the following:
> on 08/10/2012 10:52 malc said the following:
>> On Mon, 8 Oct 2012, Andriy Gapon wrote:
>>
>>>
>>> I am running Qemu (plain, no kvm, etc) on an AMD 10h machine that
>>> provides popcnt instruction.  Qemu advertises availability of pocnt
>>> to a guest as well.  What I see in the guest that popcnt
>>> 0x20(%r12),%r8 instruction actually placed its result into %rax.
>>> With %rdi and %rax operands the instruction worked fine though.
>>>
>>>
>>
>> Does following work?
> 
> It does!  Thank you very much.

Do you plan to commit this fix?
Is there anything that I should do to make that happen (sooner)?


>> diff --git a/target-i386/translate.c b/target-i386/translate.c
>> index e896abf..c36cc3e 100644
>> --- a/target-i386/translate.c
>> +++ b/target-i386/translate.c
>> @@ -7818,7 +7818,7 @@ static target_ulong disas_insn(DisasContext *s, target_ulong pc_start)
>>              goto illegal_op;
>>  
>>          modrm = cpu_ldub_code(cpu_single_env, s->pc++);
>> -        reg = ((modrm >> 3) & 7);
>> +        reg = ((modrm >> 3) & 7) | rex_r;
>>  
>>          if (s->prefix & PREFIX_DATA)
>>              ot = OT_WORD;
>>
> 
> 


-- 
Andriy Gapon