From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TMITa-0001s8-GB
	for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:07:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TMITR-0001KJ-1h
	for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:06:58 -0400
Received: from mail-da0-f45.google.com ([209.85.210.45]:53548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TMITQ-0001KD-RE
	for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:06:48 -0400
Received: by mail-da0-f45.google.com with SMTP id n15so750030dad.4
	for <qemu-devel@nongnu.org>; Thu, 11 Oct 2012 06:06:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5076C460.8020704@redhat.com>
Date: Thu, 11 Oct 2012 15:06:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com>
	<1349877786-23514-25-git-send-email-pbonzini@redhat.com>
	<5075DD61.6060501@redhat.com>
In-Reply-To: <5075DD61.6060501@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com

Il 10/10/2012 22:41, Eric Blake ha scritto:
> On 10/10/2012 08:03 AM, Paolo Bonzini wrote:
>> Adding an NBD server inside QEMU is trivial, since all the logic is
>> in nbd.c and can be shared easily between qemu-nbd and QEMU itself.
>> The main difference is that qemu-nbd serves a single unnamed export,
>> while QEMU serves named exports.
>>
>> Acked-by: Luiz Capitulino <lcapitulino@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
> 
>> +##
>> +# @nbd-server-add:
>> +#
>> +# Export a device to QEMU's embedded NBD server.
>> +#
>> +# @device: Block device to be exported
>> +#
>> +# @writable: Whether clients should be able to write to the device via the
>> +#     NBD connection (default false). #optional
> 
> Isn't the #optional designation supposed to come first, before 'Whether'?

Does it really matter with no program yet written to consume it?
Putting it at the end matches the old qmp-commands.hx format better (for
commands that do have qmp-commands.hx documentation).

Paolo