From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMIbQ-0003R1-QS for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMIbH-0003lU-7F for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:15:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMIbG-0003k2-V8 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:14:55 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9BDErx9026259 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Oct 2012 09:14:54 -0400 Message-ID: <5076C64C.1050303@redhat.com> Date: Thu, 11 Oct 2012 07:14:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349877786-23514-1-git-send-email-pbonzini@redhat.com> <1349877786-23514-25-git-send-email-pbonzini@redhat.com> <5075DD61.6060501@redhat.com> <5076C460.8020704@redhat.com> In-Reply-To: <5076C460.8020704@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig99AD5535FDDFE8546475BFCD" Subject: Re: [Qemu-devel] [PATCH 24/25] qmp: add NBD server commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig99AD5535FDDFE8546475BFCD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/11/2012 07:06 AM, Paolo Bonzini wrote: > Il 10/10/2012 22:41, Eric Blake ha scritto: >> On 10/10/2012 08:03 AM, Paolo Bonzini wrote: >>> Adding an NBD server inside QEMU is trivial, since all the logic is >>> in nbd.c and can be shared easily between qemu-nbd and QEMU itself. >>> The main difference is that qemu-nbd serves a single unnamed export, >>> while QEMU serves named exports. >>> >>> Acked-by: Luiz Capitulino >>> Signed-off-by: Paolo Bonzini >>> --- >> >>> +## >>> +# @nbd-server-add: >>> +# >>> +# Export a device to QEMU's embedded NBD server. >>> +# >>> +# @device: Block device to be exported >>> +# >>> +# @writable: Whether clients should be able to write to the device v= ia the >>> +# NBD connection (default false). #optional >> >> Isn't the #optional designation supposed to come first, before 'Whethe= r'? >=20 > Does it really matter with no program yet written to consume it? > Putting it at the end matches the old qmp-commands.hx format better (fo= r > commands that do have qmp-commands.hx documentation). I'm just asking on the grounds of consistency based on observation, and not based on an actual hard requirement of something that goes wrong if it's out of order. Therefore, I'm okay with your explanation, as long as no one else can provide hard evidence for a mandatory positioning of the marker. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig99AD5535FDDFE8546475BFCD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQdsZMAAoJEKeha0olJ0Nq/aAH/RiKZ336b+XC0fRObxAx00xM cBK9Lyz8HYShoO57C2JbQdbuiuI25OK+kyU3shRqtn6bfH7mcU6jVfBi+PpswmZi djvCJ4/gmIzUnhZwVWaEEzwgHRNweA6S7hiBgaNKCcH9JTcoJ/6mpJo2ixu3oDV+ ZgoHJu0FRFDodnmsSMFSQ/wc0N8qLRa0RbMRETEyAsWlmjunaVAEL8bMipTOoH2R D1KHayjnHW5kBA/Cmw2DdOQ7w3Ktsdms81Hf7KHEUCcEu1x8A11W2EzQ6Nx1JTTX WKZv7/oJWmRDp83mDMqGgsKQUC++oc0ITMsywglYsAtB/SkkHvcOIjRc6ejD4m8= =pqum -----END PGP SIGNATURE----- --------------enig99AD5535FDDFE8546475BFCD--