From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMItQ-00043c-Ur for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMItJ-000217-3X for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:33:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMItI-00020v-Ro for qemu-devel@nongnu.org; Thu, 11 Oct 2012 09:33:33 -0400 Message-ID: <5076CAA6.9060603@redhat.com> Date: Thu, 11 Oct 2012 15:33:26 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349962023-560-1-git-send-email-avi@redhat.com> <1349962023-560-2-git-send-email-avi@redhat.com> <5076CA24.90604@redhat.com> In-Reply-To: <5076CA24.90604@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v1 1/7] memory: fix address space initialization/destruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Michael S. Tsirkin" , liu ping fan , qemu-devel@nongnu.org, Blue Swirl , Alex Williamson , Anthony Liguori On 10/11/2012 03:31 PM, Paolo Bonzini wrote: > Il 11/10/2012 15:26, Avi Kivity ha scritto: >> A couple of fields were left uninitialized. This was not observed earlier >> because all address spaces were statically allocated. Also free allocation >> for those fields. > > Patch is obvious, but there are at least two alternatives: 1) using > memset 2) using a compound initializer. 3) std::vector<>, which also covers address_space_destroy(). -- error compiling committee.c: too many arguments to function