From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMOo7-0007aW-Oj for qemu-devel@nongnu.org; Thu, 11 Oct 2012 15:52:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMOo2-0004Oy-WB for qemu-devel@nongnu.org; Thu, 11 Oct 2012 15:52:35 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMOo2-0004On-Ny for qemu-devel@nongnu.org; Thu, 11 Oct 2012 15:52:30 -0400 Received: by mail-pa0-f45.google.com with SMTP id fb10so2083461pad.4 for ; Thu, 11 Oct 2012 12:52:29 -0700 (PDT) Sender: Richard Henderson Message-ID: <5077237B.40502@twiddle.net> Date: Thu, 11 Oct 2012 12:52:27 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1349983336-9974-1-git-send-email-rth@twiddle.net> <1349983336-9974-5-git-send-email-rth@twiddle.net> In-Reply-To: <1349983336-9974-5-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Riku Voipio On 10/11/2012 12:22 PM, Richard Henderson wrote: > The previous formuation with multiple assignments to __typeof(*hptr) falls > down when hptr is qualified const. E.g. with const struct S *p, p->f is > also qualified const. > > With this formulation, there's no assignment to any local variable. > > Signed-off-by: Richard Henderson Scratch that... I lost the unaligned access capability. I'll have to re-work the patch. r~