From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] arm_gic: Rename gic_state to GICState
Date: Thu, 11 Oct 2012 23:16:23 +0200 [thread overview]
Message-ID: <50773727.1080606@suse.de> (raw)
In-Reply-To: <1349891345-8656-1-git-send-email-peter.maydell@linaro.org>
Am 10.10.2012 19:49, schrieb Peter Maydell:
> Rename the gic_state struct to match QEMU's coding style conventions
> for structure names, since the impending KVM-for-ARM patches will
> create another subclass of it. This patch was created using:
> sed -i 's/gic_state/GICState/g' hw/arm_gic.c hw/arm_gic_common.c \
> hw/arm_gic_internal.h hw/armv7m_nvic.c
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> As suggested by Andreas...
Acked-by: Andreas Färber <afaerber@suse.de>
Builds fine and git-grep finds no further gic_state occurrences in the
tree. There's some unnecessary (GICState *) casts on the lines changed,
but if someone cares that could be fixed as followup.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-10-11 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 17:49 [Qemu-devel] [PATCH] arm_gic: Rename gic_state to GICState Peter Maydell
2012-10-11 21:16 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50773727.1080606@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).