From: Avik Sil <aviksil@linux.vnet.ibm.com>
To: David Gibson <dwg@au1.ibm.com>
Cc: qemu-ppc@nongnu.org, agraf@suse.de, nikunj@linux.vnet.ibm.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add nvram to default boot device list
Date: Fri, 12 Oct 2012 12:42:09 +0530 [thread overview]
Message-ID: <5077C2C9.4000804@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121011225934.GL25270@truffula.fritz.box>
On 10/12/2012 04:29 AM, David Gibson wrote:
> On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote:
>> This patch adds nvram specified boot device into qemu default
>> boot_devices list. This helps firmware to boot from nvram specified
>> boot device if no -boot option is specified.
>
> I really don't think this is a good idea, it extends an already
> deprecated mechanism in a fuzzy way and requires careful checking to
> see if it could break anything. On all platforms the boot sequence
> should be:
> if bootindex is specified:
> boot according to bootindex
> else if -boot is specified:
> boot according to -boot sequence
> else:
> use platform firmware default sequence
>
> The last will of course vary by platform, and could depend on platform
> details like the contents of NVRAM. Your original idea of making it
> clear to the guest when -boot has been specified (as opposed to when
> it contains its default value) was the right one, and this "x" in
> -boot is going the wrong direction.
>
I'm fine with the original approach. The patch is there in qemu-ppc m-l [1].
Regards,
Avik
[1] http://lists.nongnu.org/archive/html/qemu-ppc/2012-10/msg00081.html
prev parent reply other threads:[~2012-10-12 7:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 2:04 [Qemu-devel] [PATCH] Add nvram to default boot device list Avik Sil
2012-10-11 12:48 ` Alexander Graf
2012-10-11 22:59 ` David Gibson
2012-10-12 0:03 ` Alexander Graf
2012-10-12 0:28 ` David Gibson
2012-10-12 0:29 ` Alexander Graf
2012-10-12 3:02 ` Chris Wright
2012-10-16 11:45 ` Avik Sil
2012-10-16 3:44 ` Avik Sil
2012-10-16 8:04 ` Alexander Graf
2012-10-16 8:37 ` Andreas Färber
2012-10-12 7:12 ` Avik Sil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077C2C9.4000804@linux.vnet.ibm.com \
--to=aviksil@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=dwg@au1.ibm.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).