From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMZQH-0002Jf-0S for qemu-devel@nongnu.org; Fri, 12 Oct 2012 03:12:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMZQF-0005rd-Os for qemu-devel@nongnu.org; Fri, 12 Oct 2012 03:12:40 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:49833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMZQF-0005r0-3i for qemu-devel@nongnu.org; Fri, 12 Oct 2012 03:12:39 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Oct 2012 12:42:32 +0530 Message-ID: <5077C2C9.4000804@linux.vnet.ibm.com> Date: Fri, 12 Oct 2012 12:42:09 +0530 From: Avik Sil MIME-Version: 1.0 References: <1349921082-980-1-git-send-email-aviksil@linux.vnet.ibm.com> <20121011225934.GL25270@truffula.fritz.box> In-Reply-To: <20121011225934.GL25270@truffula.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Add nvram to default boot device list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, agraf@suse.de, nikunj@linux.vnet.ibm.com, qemu-devel@nongnu.org On 10/12/2012 04:29 AM, David Gibson wrote: > On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: >> This patch adds nvram specified boot device into qemu default >> boot_devices list. This helps firmware to boot from nvram specified >> boot device if no -boot option is specified. > > I really don't think this is a good idea, it extends an already > deprecated mechanism in a fuzzy way and requires careful checking to > see if it could break anything. On all platforms the boot sequence > should be: > if bootindex is specified: > boot according to bootindex > else if -boot is specified: > boot according to -boot sequence > else: > use platform firmware default sequence > > The last will of course vary by platform, and could depend on platform > details like the contents of NVRAM. Your original idea of making it > clear to the guest when -boot has been specified (as opposed to when > it contains its default value) was the right one, and this "x" in > -boot is going the wrong direction. > I'm fine with the original approach. The patch is there in qemu-ppc m-l [1]. Regards, Avik [1] http://lists.nongnu.org/archive/html/qemu-ppc/2012-10/msg00081.html