From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMaer-0004xn-Nr for qemu-devel@nongnu.org; Fri, 12 Oct 2012 04:31:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMaeq-0008M6-JG for qemu-devel@nongnu.org; Fri, 12 Oct 2012 04:31:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMaeq-0008M1-B5 for qemu-devel@nongnu.org; Fri, 12 Oct 2012 04:31:48 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9C8Vln5011729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Oct 2012 04:31:47 -0400 Message-ID: <5077D571.3020101@redhat.com> Date: Fri, 12 Oct 2012 10:31:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349990825-2659-1-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1349990825-2659-1-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/7] block: bdrv_img_create(): propagate errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com Il 11/10/2012 23:26, Luiz Capitulino ha scritto: > I'm calling this an RFC because I did it on hurry and it's almost untested, > but I wanted to drop it for early review while I'm out for a public holiday :) > > This should improve qmp_transaction() error messages on bdrv_img_create() > failure quite a bit. Also, the "formatting" message is not printed to stdout > anymore when in QMP. > > Luiz Capitulino (6): > block: bdrv_img_create(): add param_ret argument > block: bdrv_img_create(): move param printing to qemu-img > block: bdrv_img_create(): add Error ** argument > qemu-img: img_create(): use Error object > qmp: qmp_transaction(): pass Error object to bdrv_img_create() > block: bdrv_img_create(): drop unused code > > Paolo Bonzini (1): > error: add error_set_errno and error_setg_errno > > block.c | 69 +++++++++++++++++++++++++++----------------------------------- > block.h | 7 ++++--- > blockdev.c | 13 ++++++------ > error.c | 28 +++++++++++++++++++++++++ > error.h | 9 ++++++++ > qemu-img.c | 18 +++++++++++++--- > 6 files changed, 93 insertions(+), 51 deletions(-) > Looks good. We could debate endlessly how to order the patches, but the idea is fine. Paolo