From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMcp1-00060c-Ml for qemu-devel@nongnu.org; Fri, 12 Oct 2012 06:50:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMcox-0007yi-M8 for qemu-devel@nongnu.org; Fri, 12 Oct 2012 06:50:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMcox-0007yY-ES for qemu-devel@nongnu.org; Fri, 12 Oct 2012 06:50:23 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9CAoLQK032175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Oct 2012 06:50:22 -0400 Message-ID: <5077F5EB.1080103@redhat.com> Date: Fri, 12 Oct 2012 12:50:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1350033962-16665-1-git-send-email-kraxel@redhat.com> <1350033962-16665-8-git-send-email-kraxel@redhat.com> <5077EF88.2070708@redhat.com> In-Reply-To: <5077EF88.2070708@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Il 12/10/2012 12:23, Gerd Hoffmann ha scritto: >> I suggest that you implement the commands in a similar way as netdev_add. > > Why? Isn't the whole point of using josn is that you'll get the stuff > from the josn parser & marshaller in a usable form instead of having it > to feed into yet another parser? I think the only reason netdev_add > exists in the current form is that it predates qmp. In principle you're right, but I think it's ugly that adding another chardev argument needs changes in 3 places instead of just one. (And I'd like to add another argument soon enough...). Paolo