From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/7] chardev: add hotplug support.
Date: Fri, 12 Oct 2012 13:17:53 +0200 [thread overview]
Message-ID: <5077FC61.50708@redhat.com> (raw)
In-Reply-To: <5077FBE6.2040107@redhat.com>
Il 12/10/2012 13:15, Gerd Hoffmann ha scritto:
>> > In principle you're right, but I think it's ugly that adding another
>> > chardev argument needs changes in 3 places instead of just one.
> Hmm, I don't have to use the generated marshaller, right? With direct
> access to the QDict I could just transform it into a QemuOpts.
That's exactly what I was suggesting. :P
> A new parameter wouldn't need code changes then. And the code would be
> reusable and probably also be simpler. The qapi schema still needs
> an update though.
The QAPI schema is only used by the generated marshaller.
> HMP is more tricky, but I think we should sort QMP first.
HMP can just take a string, parse it into QemuOpts, and call a small
wrapper that calls qemu_chr_new_from_opts and returns errors via Error.
Paolo
next prev parent reply other threads:[~2012-10-12 11:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 9:25 [Qemu-devel] [PULL 0/7] serial device hotplug patch series Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 1/7] serial: split serial.c Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 2/7] serial: add pci variant Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 4/7] serial: add 2x + 4x pci variant Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 5/7] usb-serial: don't magically zap chardev on umplug Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when the chardev is open Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 7/7] chardev: add hotplug support Gerd Hoffmann
2012-10-12 9:40 ` Paolo Bonzini
2012-10-12 10:23 ` Gerd Hoffmann
2012-10-12 10:50 ` Paolo Bonzini
2012-10-12 11:15 ` Gerd Hoffmann
2012-10-12 11:17 ` Paolo Bonzini [this message]
2012-10-12 12:37 ` Gerd Hoffmann
2012-10-12 12:39 ` [Qemu-devel] [PATCH v2] " Gerd Hoffmann
2012-10-12 13:12 ` Gerd Hoffmann
2012-10-12 16:54 ` Paolo Bonzini
2012-10-12 17:08 ` Paolo Bonzini
2012-10-15 6:51 ` Lei Li
2012-10-15 11:09 ` Andreas Färber
2012-10-16 13:23 ` Luiz Capitulino
2012-10-15 17:36 ` Eric Blake
2012-10-16 14:02 ` Paolo Bonzini
2012-10-12 9:42 ` [Qemu-devel] [PULL 0/7] serial device hotplug patch series Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077FC61.50708@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).