From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39542) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TN9O2-00074B-0k for qemu-devel@nongnu.org; Sat, 13 Oct 2012 17:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TN9O0-0006Dn-Pw for qemu-devel@nongnu.org; Sat, 13 Oct 2012 17:36:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TN9O0-0006Da-HK for qemu-devel@nongnu.org; Sat, 13 Oct 2012 17:36:44 -0400 Message-ID: <5079DEE4.5060602@redhat.com> Date: Sat, 13 Oct 2012 15:36:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1350050969-14034-1-git-send-email-stefanha@redhat.com> <50787E36.2090308@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6602F472A0DB9E7999CA786A" Subject: Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , =?ISO-8859-1?Q?Beno=EEt_Canet?= This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6602F472A0DB9E7999CA786A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/13/2012 09:50 AM, Kashyap Chamarthy wrote: >=20 > [PS: I haven't used 'git-send-email' for this trivial patch. Should I > have used that, instead of attaching it? I was wondering if > attachments like these are frowned upon. ] That depends on who is applying the patch (it won't be me, since I'm not listed as maintainer); but even in my view as a reviewer, attachments embedded to a lengthy chain of reply text is harder to reply to than a fresh thread. So, given that I have review comments below, you might as well use 'git send-email' to post a v2 as a fresh thread, so we don't have to worry about whether this will be spotted deeply embedded in a thread. > From 68b22497ad1c9318ae57092f7e6af543b4106e1b Mon Sep 17 00:00:00 2001 > From: Kashyap Chamarthy > Date: Sat, 13 Oct 2012 20:54:28 +0530 > Subject: [PATCH] Add documentation for 'qemu-img info --backing-chain' = (with > Eric's comments fixed) The subject line becomes part of the permanent git history, and as such, it should avoid versioning information, and just describe the change (or in other words, leave my name out of the 'git log --one-line' output). Better would be: qemu-img: document 'info --backing-chain' >=20 > Signed-off-by: Kashyap Chamarthy > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.texi | 19 ++++++++++++++++++- > 2 files changed, 20 insertions(+), 3 deletions(-) >=20 > =20 > +@item --backing-chain=20 > +will enumerate information about backing files in a disk image chain. = Refer > +below for further description. > + > @item size > is the disk image size in bytes. Optional suffixes @code{k} or @code{K= } > (kilobyte, 1024) @code{M} (megabyte, 1024k) and @code{G} (gigabyte, 10= 24M) > @@ -129,7 +133,7 @@ created as a copy on write image of the specified b= ase image; the > @var{backing_file} should have the same content as the input's base im= age, > however the path, image format, etc may differ. > =20 > -@item info [-f @var{fmt}] [--output=3D@var{ofmt}] @var{filename} > +@item info [-f @var{fmt}] [--output=3D@var{oft}] [--backing-chain] @va= r{filename} Last time, you added a spurious 'a'; this time, you accidentally nuked an 'm'. Please, leave @var{ofmt} untouched. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6602F472A0DB9E7999CA786A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQed7kAAoJEKeha0olJ0NqhXwH/0/rwlp+KNwTzWnMVuwOeCFh WFnZupmf1Qvv5qXVl6XzmVNDwCoXubHyDOvKaZopI/Cr+AXpRyNPq/94+KZPBUUf tUEvjmbb+W8bgBdS+ZoT9UX2BYoFZwcb52G2wCxyT8++bWhk4fg9D0aYs29gbiKi Ai68r5H6lSoP5sdRT7pfwJKQmpZKqz1Xgw3feFvtWEdMuvmj4nrmxNVyVOzfWSG6 0WyR/3y3N1DXbkdF+mbrrujDamy3V4qe3g0ax3eLWAUbRVP9D0kFxaIPd7lM+4Zs ceOmjeavkDI88OQsLLbIkCxon1uV28JIipztuRN9PJnccnORampmgRjjJmkVFxs= =Djcg -----END PGP SIGNATURE----- --------------enig6602F472A0DB9E7999CA786A--