From: "Andreas Färber" <afaerber@suse.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions
Date: Mon, 15 Oct 2012 02:01:12 +0200 [thread overview]
Message-ID: <507B5248.9020600@suse.de> (raw)
In-Reply-To: <CAAu8pHu5cuBML84JehNbXXsbuJ=3KwauuAvOYP=+VH-Y_GQ+-g@mail.gmail.com>
Am 14.10.2012 22:33, schrieb Blue Swirl:
> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Please don't delete this function, it is the public facing interface
>> for allowing board models to attach NAND devices to the GPMC. This
>> might not be used by anything currently in mainline, but it is used
>> by the omap3 beagle and overo board models in qemu-linaro (and which
>> I will upstream eventually, honest).
>
> It could be re-added with the boards, or just disabled now with #if 0/#endif.
#if 0 would make things worse, since then no compile-time checking of
the code is performed and it just rots, as seen with DPRINTF().
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-10-15 0:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 19:58 [Qemu-devel] [PATCH 00/11] static patches Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 01/11] target-sparc: make do_unaligned_access static Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 02/11] vl.c: add missing static Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 03/11] vnc: add missing static and remove unused functions Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 04/11] tap-win32: avoid a warning Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 05/11] m48t59: remove unused m48t59_set_addr Blue Swirl
2012-10-15 0:04 ` Andreas Färber
2012-10-14 19:58 ` [Qemu-devel] [PATCH 06/11] sun4c: remove unused functions Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 07/11] slirp: remove unused function u_sleep Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 08/11] ppc: add missing static and remove unused functions Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 09/11] target-ppc: make some functions static Blue Swirl
2012-10-14 19:58 ` [Qemu-devel] [PATCH 10/11] arm: add missing static and remove unused functions Blue Swirl
2012-10-14 20:09 ` Peter Maydell
2012-10-14 20:33 ` Blue Swirl
2012-10-14 20:35 ` Peter Maydell
2012-10-14 20:49 ` Blue Swirl
2012-10-14 20:55 ` Peter Maydell
2012-10-19 16:43 ` Blue Swirl
2012-10-15 0:01 ` Andreas Färber [this message]
2012-10-14 19:58 ` [Qemu-devel] [PATCH 11/11] exec: make some functions static Blue Swirl
2012-10-14 20:06 ` [Qemu-devel] [PATCH 00/11] static patches Blue Swirl
2012-10-14 20:32 ` malc
2012-10-14 20:41 ` Blue Swirl
2012-10-19 8:38 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-10-19 17:49 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507B5248.9020600@suse.de \
--to=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).