From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55710)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TNdnT-0004zV-C4
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 02:05:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TNdnS-0001Au-3I
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 02:05:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63250)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TNdnR-00018G-Rv
	for qemu-devel@nongnu.org; Mon, 15 Oct 2012 02:05:02 -0400
Message-ID: <507BA786.4040804@redhat.com>
Date: Mon, 15 Oct 2012 08:04:54 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1348732073-18986-1-git-send-email-kraxel@redhat.com>
	<5076B0DC.9010806@redhat.com>
	<CAAu8pHsauwr15DBgiSju+NoqDVpkKgb7EjE8kGvZ=82Dq+kowQ@mail.gmail.com>
In-Reply-To: <CAAu8pHsauwr15DBgiSju+NoqDVpkKgb7EjE8kGvZ=82Dq+kowQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] vga: add mmio bar
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

  Hi,

> Patches don't apply, please rebase:
> Applying: vga: add mmio bar to standard vga
> error: patch failed: hw/pc_piix.c:371
> error: hw/pc_piix.c: patch does not apply
> error: patch failed: hw/vga-pci.c:47
> error: hw/vga-pci.c: patch does not apply
> Patch failed at 0001 vga: add mmio bar to standard vga

Rebased & resolved.

> Also checkpatch.pl complains for 1/3:
> WARNING: suspect code indent for conditional statements (5, 9)
> #212: FILE: hw/vga-pci.c:158:
> +     if (d->flags & (1 << PCI_VGA_FLAG_ENABLE_MMIO)) {
> +         memory_region_init(&d->mmio, "vga.mmio", 4096);

Ah, finally figured where this comes from.  It's not in this patch, but
the *existing* intention is wrong (5 instead of 4 spaces).  Fixed.

v2 is on the way.

cheers,
  Gerd