From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNfmx-0007Fz-Pa for qemu-devel@nongnu.org; Mon, 15 Oct 2012 04:12:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNfms-0007pV-3t for qemu-devel@nongnu.org; Mon, 15 Oct 2012 04:12:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNfmr-0007pM-Rr for qemu-devel@nongnu.org; Mon, 15 Oct 2012 04:12:34 -0400 Message-ID: <507BC568.10504@redhat.com> Date: Mon, 15 Oct 2012 10:12:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1350076268-18461-1-git-send-email-mdroth@linux.vnet.ibm.com> <1350076268-18461-25-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1350076268-18461-25-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com Il 12/10/2012 23:11, Michael Roth ha scritto: > + elif field['type'].startswith('enum '): > + typename = 'int' Note that there is support for enum properties in qdev. Please consider adding it, though it can be done as a follow-up. I'm going to play a bit with the series and convert 1 or 2 devices myself to see how it looks, then I'll give my acked-by. Paolo