Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level

["Andreas Färber" <afaerber@suse.de>]

Am 15.10.2012 13:54, schrieb Igor Mammedov:
> On Sun, 14 Oct 2012 06:09:56 +0200
> Andreas Färber <afaerber@suse.de> wrote:
> 
>> Am 13.10.2012 22:35, schrieb Igor Mammedov:
>>> (L)APIC is a part of cpu [1] so move APIC initialization inside of
>>> x86_cpu object. Since cpu_model and override flags currently specify
>>> whether APIC should be created or not, APIC creation&initialization is
>>> moved into x86_cpu_apic_init() which is called from x86_cpu_realize().
>>>
>>> [1] - all x86 cpus have integrated APIC if we overlook existence of i486,
>>> and it's more convenient to model after majority of them.
>>>
>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>> ---
>>>   v5: fix *-user target build, smp_cpus is defined for softmmu only
>>
>> I do not run into any build issue with v4. Is it a runtime issue?
>>
>> Andreas
>>
> I've run into this trying to build your latest CPUstate series with
> following configure options:
>   './configure' '--enable-debug'  '--target-list=x86_64-softmmu,x86_64-linux-user'

--enable-debug was the missing puzzle piece, now I get the undefined
reference warning, too. :)

> Anyway it's better not to build in any APIC checks in user target since it
> doesn't need it at all.
> 
> I'm sorry for not noticing error earlier at v4 build time.
> Could you re-apply it, please?

Sure, the patch itself is indeed better. Now that I've been able to
reproduce, I've exchanged v4 against v5 in on qom-cpu queue:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Thanks for noticing,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg