From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/8] console: add unregister_displaychangelistener
Date: Mon, 15 Oct 2012 16:16:55 +0200 [thread overview]
Message-ID: <507C1AD7.9030406@suse.de> (raw)
In-Reply-To: <1350294703-22011-3-git-send-email-kraxel@redhat.com>
Am 15.10.2012 11:51, schrieb Gerd Hoffmann:
> Also change the way the gui_timer is initialized: each time a
> displaychangelistener is registered or unregistered we'll check
> whenever we need a timer (due to dpy_refresh callback being present)
"whether"
> and if so setup a timer, otherwise zap it. This way the gui timer works
> correctly with displaychangelisteners coming and going.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Logic looks okay to me.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-10-15 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 9:51 [Qemu-devel] [PATCH 0/8] console cleanups Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 1/8] console: QLIST-ify display change listeners Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 2/8] console: add unregister_displaychangelistener Gerd Hoffmann
2012-10-15 14:16 ` Andreas Färber [this message]
2012-10-15 9:51 ` [Qemu-devel] [PATCH 3/8] console: move set_mouse + cursor_define callbacks Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 4/8] console: s/TextConsole/QemuConsole/ Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 5/8] console: untangle gfx & txt updates Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 6/8] console: init displaychangelisteners on register Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 7/8] vga: fix text mode updating Gerd Hoffmann
2012-10-15 9:51 ` [Qemu-devel] [PATCH 8/8] console: remove dpy_gfx_fill Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C1AD7.9030406@suse.de \
--to=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).