From: Eric Blake <eblake@redhat.com>
To: Alex Bligh <alex@alex.org.uk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-'
Date: Mon, 15 Oct 2012 12:07:37 -0600 [thread overview]
Message-ID: <507C50E9.1050706@redhat.com> (raw)
In-Reply-To: <CD6AD65A07E882F403F4BA91@Ximines.local>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On 10/15/2012 11:29 AM, Alex Bligh wrote:
> This patch allows qemu-img rebase to rebase an image to
> have no backing file, as opposed to merely allowing it to
> rebase to an existing backing file.
You can already do that by rebasing to the empty string. And it is
feasible (although unlikely) to have a file named '-', where your patch
would make it impossible to use that file directly (although you could
still use './-'). NACK.
$ qemu-img info bar
image: bar
file format: qcow2
virtual size: 0 (0 bytes)
disk size: 192K
cluster_size: 65536
backing file: foo
$ qemu-img rebase -u -b '' bar
$ qemu-img info bar
image: bar
file format: qcow2
virtual size: 0 (0 bytes)
disk size: 192K
cluster_size: 65536
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-15 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 17:29 [Qemu-devel] [PATCH] qemu-img rebase: allow backing file to be specified as '-' Alex Bligh
2012-10-15 18:07 ` Eric Blake [this message]
2012-10-15 18:11 ` Eric Blake
2012-10-15 18:42 ` Alex Bligh
2012-10-15 19:28 ` Eric Blake
2012-10-15 20:28 ` Alex Bligh
2012-10-23 16:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C50E9.1050706@redhat.com \
--to=eblake@redhat.com \
--cc=alex@alex.org.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).